Previous Next Tracker index See it online !

(289/309) 1758 - Common Controls - "Close Blame" competes with ColumnRuler

Both the SVN and git plugins provide a Blame action that establishes an area at the right side of text area. At it's top a "Close Blame" button is placed, which seems to be provided by Common Controls plugin. The "Close Blame" button uses the same place as the ColumnRuler plugin to show the ColumnRuler. Now, having enabled both ColumnRuler and Blame there are visibility issues.

Steps to reproduce:
- Enable ColumnRuler visibility
- Enable Blame (SVN or git)
- Go to another open buffer - ColumnRuler isn't shown anymore
- Disable and Re-Enable ColumnRuler visibility - ColumnRuler will be shown
- Go back to the blamed buffer - The "Close Blame" button isn't there
and so on

Submitted	rschwenn - 2013-12-07 13:52:27	Assigned	daleanson
Priority	5	Labels
Status	open	Group
Resolution	None

Comments

2013-12-07 15:35:00 daleanson	I think this should be an easy fix. I thought that the text area was using a BorderLayout for the components around the edges, but in fact, it's using a ScrollPaneLayout, which means the "Close Blame" button can be placed in a corner rather than at the top edge where the ColumnRuler is located.
2013-12-07 15:35:00 daleanson	- assigned_to: nobody --> daleanson
2013-12-07 15:47:10 daleanson	Well, I thought this was an easy fix, but the text area is not using a ScrollPaneLayout, it's using a custom ScrollLayout, which doesn't have corners.
2013-12-07 18:25:47 daleanson	I added a patch to the tracker to change the layout manager for the main text area: https://sourceforge.net/tracker/?func=detail&aid=3615266&group_id=588&atid=300588 Once this is applied, it is a very simple change to move the "Close Blame" button so it doesn't interfere with ColumnRuler.
2014-03-31 22:52:03.602000 daleanson	Reminder for when jEdit 5.2 is released -- the patch mentioned above is applied, and I've made small changes to both CommonControls and ColumnRuler to work with the change. Both of these plugins will need to be released after 5.2 is released. The changes can be seen/used now when building jEdit and the plugins from source.
2014-03-31 22:53:08.892000 daleanson	- status: open --> pending-fixed - Group: -->
2014-04-19 03:46:35.232000 ezust	You can still commit your changes to commoncontrols. I am waiting to test them.
2014-04-19 03:46:46.939000 ezust	- status: pending-fixed --> open